[PATCH] BUG 189643 Taskbar should be animated while program is starting

[潘卫平]

Aaron J. Seigo 写道:
> On Thursday 23 July 2009, 潘卫平(Peter Pan) wrote:
>> Taht will cover the icon and looks mussy.
>> I prefer to let it over the text.
>
> hm.. ok, how about on the right side of the button then, where the # of
> windows usually appears when there are several windows grouped?
>
> also as for this:
>
> +    QRectF rect = parentGroup()->tasksLayout()->contentsRect();
> +    int rowCount = parentGroup()->tasksLayout()->rowCount();
> +    qreal height = rect.height() / rowCount;
> +    QSizeF size(height, height);
>
> it should be able to just position it relative to the task button itself,
> something like this which would make it consistent with the group number
> drawing as well:
>
> Plasma::FrameSvg *itemBackground = m_applet->itemBackground();
> QSizeF busySize(itemBackground->elementSize(expanderElement()));
> QRectF animationRect(QPointF(size().width() - busySize.width(),
(size.height()
> - busySize.height())  / 2), busySize);
>
> even with this code, however, if the size of the button changes while the
app
> is launching the busy widget will no longer be in the right place.
>
> so ... either the positioning code should be put into a separate method
and be
> called from both startStartupAnimation and resizeEvent or a layout should
be
> used to manage that for us. a layout is probably overkill in this
situation,
> though.
>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel

Fisrt, I prefer to use Plasma::BusyWidget, consistent with others.

Second, I prefer to replace icon when the app is starting up, like
firefox when it is opening a new website.

Third, I set the BusyWidgest's geometry in AbstractTaskItem::drawTask(),
so it can get the proper geometry.

Best regards!


-- 
潘卫平(Peter Pan)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20090729/8d87000e/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdebase-plasma-tasks-startup-animator.patch
Type: text/x-patch
Size: 4983 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090729/8d87000e/attachment.patch