Review Request: Fix pager applet for vertical panels

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1123/#review1763
-----------------------------------------------------------


is this a different fix for the same problem that's addressed by the other patch?

and yes, the rows MUST be the same right now in all pagers, as Chani noted on the mailing list.

- Aaron


On 2009-07-25 01:13:24, michael wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1123/
> -----------------------------------------------------------
> 
> (Updated 2009-07-25 01:13:24)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This is an attempt to fix the pager applet for vertical panels.
> There are currently two problems:
> 1. The configuration file always contains the number of rows. This is shared between all pager applets. This makes it basically impossible to have a pager on both a vertical and a horizontal panel. One of the two is always too small.
> 2. The parameter for setPreferredSize() is wrong. As a result, a large part of the pager disappears behind the next applet.
> 
> With this patch the config value contains the number of rows for horizontal panels and the number of columns for vertical panels.
> As a side effect, changing a panel from horizontal to vertical does now the right thing (imho): One row is turned into on column.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/pager/pager.cpp 1001981 
> 
> Diff: http://reviewboard.kde.org/r/1123/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> michael
> 
>