Review Request: Sleep/Hibernate in Lock/Log out plasma applet

[Marco Martin]

On Wednesday 15 July 2009, Frederik Gladhorn wrote:
> > On 2009-07-15 11:16:26, Marco Martin wrote:
> > > it seems just fine, for the  buttns becoming small well, i don't see
> > > other ways beside making the applet bigger no? :) you could try to do a
> > > resize(layout->effectiveSizeHint(PreferredSize)) when changing the
> > > number of buttons, it should automatically resize the applet when in
> > > desktop
>
> I was wondering if it would be possible to maybe switch to a grid layout
> when in panel with >2 buttons, that might work.

possible yeah, you could also always use a grid layout, just to switch between 
one and two columns :)
>
> - Frederik
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1031/#review1613
> -----------------------------------------------------------
>
> On 2009-07-14 21:56:47, Frederik Gladhorn wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/1031/
> > -----------------------------------------------------------
> >
> > (Updated 2009-07-14 21:56:47)
> >
> >
> > Review request for Plasma.
> >
> >
> > Summary
> > -------
> >
> > Display Sleep and Hibernate buttons in Lock/Log out plasma applet.
> > By default they are hidden in the config.
> > Functionality is there, some code copied from powerdevil/battery applet.
> > Having more than two buttons visible makes the buttons become too small -
> > maybe someone has an idea to improve the layout?
> >
> >
> > Diffs
> > -----
> >
> >   trunk/KDE/kdebase/workspace/plasma/applets/lock_logout/CMakeLists.txt
> > 996693 
trunk/KDE/kdebase/workspace/plasma/applets/lock_logout/lockout.h
> > 996693 
trunk/KDE/kdebase/workspace/plasma/applets/lock_logout/lockout.cpp
> > 996693
> > trunk/KDE/kdebase/workspace/plasma/applets/lock_logout/lockoutConfig.ui
> > 996693
> >
> > Diff: http://reviewboard.kde.org/r/1031/diff
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Frederik