Making paths case insensitive in krunner
Diaa Sami
diaasami at gmail.com
Tue Jan 20 00:10:13 CET 2009
On Mon, 19 Jan 2009 11:08 -0700, "Aaron J. Seigo" <aseigo at kde.org> wrote:
>
> however, the code itself needs to be written following our coding style
> guidelines:
>
> http://techbase.kde.org/Policies/Kdelibs_Coding_Style
>
> qDebug should be kDebug; QString whatever = "" should be
> whatever.isEmpty();
> there's an assert Q_ASSERT(components.size() > 1) when it it is handled
> almost
> alright by the very next line of code (which should probably be "if
> (components.size() < 2), actually, to guard against the zero case); the
> QString *s in the two helper functions should be QString &s;
> CorrectPathCase
> should be correctPathCase (it's a function, not a method).
>
Find the new version attached
--
Diaa Sami
-------------- next part --------------
A non-text attachment was scrubbed...
Name: krunner-caseinsensitive-paths2.patch
Type: text/x-diff
Size: 4064 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090120/1134070a/attachment.bin
More information about the Plasma-devel
mailing list