Review Request: support brightness keys in the battery applet.

Matt Rogers mattr at kde.org
Sun Jan 18 21:22:12 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/335/
-----------------------------------------------------------

(Updated 2009-01-18 12:22:12.793310)


Review request for Plasma.


Summary
-------

This patch adds support for laptop brightness keys on X11. Qt doesn't support these keys yet, so this has to be implemented in a platform specific way and I have provided support for them on X11. 

There is no OSD or other indication that the keys work other than the change in brightness.


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/applets/battery/CMakeLists.txt
  /trunk/KDE/kdebase/workspace/plasma/applets/battery/battery.h
  /trunk/KDE/kdebase/workspace/plasma/applets/battery/battery.cpp

Diff: http://reviewboard.vidsolbach.de/r/335/diff


Testing
-------

compiled, installed, and verified the keys do work.


Thanks,

Matt



More information about the Plasma-devel mailing list