battery applet - charge time instead of charge percentage.

Sebastian Kügler sebas at kde.org
Wed Jan 7 21:40:13 CET 2009


On Wednesday 07 January 2009 21:17:57 Marcos Dione wrote:
> On Tue, Jan 06, 2009 at 03:32:04AM +0100, Sebastian Kügler wrote:
> > - the changes in updateStatus() seem a bit random, and I don't grok all
> > of them, would be good if it was removed.
> > - Making the label wider than 4 chars starts to randomly stretch it. We
> > need a way to keep that label small and clean. Definitely no localized
> > string though. Remember that the applet as such is supposed to work at
> > small sizes like 22x22 pixels (maybe you can make it display more
> > information only when there's enough space?)
> > - Cleanup of commented stuff and debugging
>
>     cleaner patch attached.

Looks good. Two minor things, however:

- 100% might not be correct, my battery often is fully charged at 98%, display 
the actual charge rate there
- showLabel() in configAccepted() should probably happen later, it can change 
in the course of this funtion (unless I'm missing something)

Otherwise, please commit. And thanks :)
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 



More information about the Plasma-devel mailing list