Review Request: simple animation of tabbar icons everytime kickoff is launched by pressing the KDE start button

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/63/#review248
-----------------------------------------------------------


posting a screencast would be helpful so people can see what it does.


trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.cpp
<http://reviewboard.kde.org/r/63/#comment142>

    instead of another variable here, why not just check for
    
    !qFuzzyCompare(m_introAnimProgress, 1.0)?
    
    because if it == 1.0, then the animation is complete  :)



trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.cpp
<http://reviewboard.kde.org/r/63/#comment141>

    more easily, readably and correctly written as:
    
    m_introAnimProgress = value;
    
    if (qFuzzyCompare(m_introAnimProgress, 1.0)) {
        m_dointIntroAnimation = false;
    }
    
    update();


- Aaron


On 2009-02-14 00:58:27, Mohammad Mehdi Salem Naraghi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/63/
> -----------------------------------------------------------
> 
> (Updated 2009-02-14 00:58:27)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> A little animation that mimics the behaviour of my sony erricsson handy whenever I get to the main menu. The Icons in kickoff's tabbar are all placed at the center of the tabbar before moving towards their intended location when the menu is displayed. It's a hack as of now and doesn't even work when the panel is placed on the right or left screen edge. But that's pretty easy to fix if you guys like that behaviour. I am not sure, maybe the thing is superfluous but hey, I like small useless animations. 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.h 925803 
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.cpp 925803 
> 
> Diff: http://reviewboard.kde.org/r/63/diff
> 
> 
> Testing
> -------
> 
> the animation doesn't work (yet) if the panel is placed on the right or left screen edge. But adding support for that is pretty straightforward.
> 
> 
> Thanks,
> 
> Mohammad Mehdi
> 
>