Review Request: Sets the focus for widget in Plasma::Dialog on show

[Ivan Cukic]

> On 2009-02-23 11:07:49, Aaron Seigo wrote:
> > /trunk/KDE/kdelibs/plasma/dialog.cpp, lines 424-427
> > <http://reviewboard.kde.org/r/161/diff/2/?file=1159#file1159line424>
> >
> >     shouldn't this be:
> >     
> >     if (d->widget) {
> >         d->widget->setFocus();
> >     }
> >     
> >     if (d->view) {
> >         d->view->setFocus();
> >     }
> >     
> >     slightly more correct, i imagine.

Ok, I'll change that, although there is not much point in having a Plasma::Dialog that has view and not widget, and vice versa.


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/161/#review244
-----------------------------------------------------------


On 2009-02-23 06:55:27, Ivan Cukic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/161/
> -----------------------------------------------------------
> 
> (Updated 2009-02-23 06:55:27)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Sets the focus of the view and the QGWidget that is contained in this Plasma::Dialog on show event.
> 
> Note that this doesn't steal the focus from another application. It just tells the Qt that when this Plasma::Dialog gets the /global/ focus, that the plasma widget contained inside should receive the input.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/dialog.cpp 929387 
> 
> Diff: http://reviewboard.kde.org/r/161/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan
> 
>