Review Request: Sets the focus for widget in Plasma::Dialog on show

Aaron Seigo aseigo at kde.org
Mon Feb 23 20:07:46 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/161/#review244
-----------------------------------------------------------


as long as this doesn't result in the dialog actually taking focus from other apps when popped up, it seems sensible.


/trunk/KDE/kdelibs/plasma/dialog.cpp
<http://reviewboard.kde.org/r/161/#comment136>

    shouldn't this be:
    
    if (d->widget) {
        d->widget->setFocus();
    }
    
    if (d->view) {
        d->view->setFocus();
    }
    
    slightly more correct, i imagine.


- Aaron


On 2009-02-23 06:55:27, Ivan Cukic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/161/
> -----------------------------------------------------------
> 
> (Updated 2009-02-23 06:55:27)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Sets the focus of the view and the QGWidget that is contained in this Plasma::Dialog on show event.
> 
> Note that this doesn't steal the focus from another application. It just tells the Qt that when this Plasma::Dialog gets the /global/ focus, that the plasma widget contained inside should receive the input.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/dialog.cpp 929387 
> 
> Diff: http://reviewboard.kde.org/r/161/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan
> 
>



More information about the Plasma-devel mailing list