[PATCH] To make Plasma Applet System Monitor - Network to display interface names above graphs.

[Shantanu Jha]

1. Please find the screenshot here
http://www.shantanutushar.com/screenshots/plasmoid_sm_net.jpg .

2. Though I think It looks good, but still, the user should be free to
decide on it.

3. I've uploaded the backtrace at
http://www.shantanutushar.com/plasmoidviewer.kcrash . I was running the
latest svn kdebase build when the backtrace was saved. Further, applets *other
than* System Monitor - CPU, System Monitor - Network, System Monitor -
Temperature were working fine.

Hope this helps :)


2009/2/20 Aaron J. Seigo <aseigo at kde.org>:
> On Thursday 19 February 2009, Shantanu Jha wrote:
>> The attached patch applies to the directory
>> kdebase/workspace/plasma/applets/system-monitor of trunk.
>
> can you provide a screenshot as well? for patches that touch visible UI,
we
> encourage providing a screenshot as well. it allows those who can't
compile
> the code to keep up with visual changes (e.g. our designers :)
>
>> This patch adds functionality to the Plasma Applet System Monitor -
>> Network so that It gives the user an option to display the interface
>> name and instantaneous traffic above the respective interface's graph.
>> This is useful as not having a title takes away meaning from any
>> graph. The user can enable or disable this feature using the Settings
>> Dialog.
>
> if it looks good, i don't see any reason to make it an option.
>
>> Please note that I've tested the build successfully against the latest
>> SVN trunk build of kdebase, with the exception of
>> kdebase/workspace/plasma/dataengines/systemmonitor/systemmonitor.cpp
>> which I used as of revision 926166 . Because after this revision,
>> systemmonitor.cpp is causing even the original applet to crash.
>
> can you provide a backtrace for this? thanks...
>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Qt Software
>
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>



-- 
Shantanu Tushar
http://www.shantanutushar.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20090220/29012047/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: system-monitor-network.diff
Type: text/x-diff
Size: 5463 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090220/29012047/attachment.bin