[PATCH] To make Plasma Applet System Monitor - Network to display interface names above graphs.

Aaron J. Seigo aseigo at kde.org
Thu Feb 19 21:12:05 CET 2009


On Thursday 19 February 2009, Shantanu Jha wrote:
> The attached patch applies to the directory
> kdebase/workspace/plasma/applets/system-monitor of trunk.

can you provide a screenshot as well? for patches that touch visible UI, we 
encourage providing a screenshot as well. it allows those who can't compile 
the code to keep up with visual changes (e.g. our designers :)

> This patch adds functionality to the Plasma Applet System Monitor -
> Network so that It gives the user an option to display the interface
> name and instantaneous traffic above the respective interface's graph.
> This is useful as not having a title takes away meaning from any
> graph. The user can enable or disable this feature using the Settings
> Dialog.

if it looks good, i don't see any reason to make it an option.

> Please note that I've tested the build successfully against the latest
> SVN trunk build of kdebase, with the exception of
> kdebase/workspace/plasma/dataengines/systemmonitor/systemmonitor.cpp
> which I used as of revision 926166 . Because after this revision,
> systemmonitor.cpp is causing even the original applet to crash.

can you provide a backtrace for this? thanks...

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090219/4310cc05/attachment.sig 


More information about the Plasma-devel mailing list