Review Request: Plasma::Webview

[Aaron J. Seigo]

On Sunday 01 February 2009, 0xDeadC0de wrote:
> I'd like to request that plasma webview become full on QWebViews instead
> of QWebPages.

proxying a widget when we can paint directly to canvas would be a step 
backwards.

let's look at the four issues you describe:

* properly accept left clicks

i don't even know what that means. you'll need to be more specific

* properly accept right clicks

ditto

* context menu creation

WebView makes the exact same call as QWebView does there. what i don't think 
we're doing is calling updatePositionDependentActions and 
swallowContextMenuEvent, and that might be the difference?

* calls downloadRequested

probably related to the issue above.

attached is an untested patch that might help; if you could provide some test 
cases that i could use to test the exact behaviour you're expecting i could 
perhaps even test it. ;) in the meantime, feel free to try the patch.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

-------------- next part --------------
A non-text attachment was scrubbed...
Name: webview.diff
Type: text/x-patch
Size: 690 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090201/47230877/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090201/47230877/attachment.sig