animation api changes

[Akmanalp, Mehmet A]

On Thu, Dec 3, 2009 at 8:24 PM, Aaron J. Seigo <aseigo at kde.org> wrote:

> * Plasma::Animation IsA QAbstractAnimation with the bare essential pure
> virtuals implemented and which takes a QGraphicsWidget that should be animated
Good call, I forget the reasoning of why we didn't do it this way
initially but I guess it's moot now.

> * Plasma::AnimationGroup IsA QAbstractAnimation that wraps a
> QAbstractAnimationGroup (this is the part i'm least sure about atm...) and
> makes switching from parallel to sequential easy (personally, i think Kinetic
> should have made parallel vs sequential a property, not introduced two
> different classes; it's a hassle).
Completely agree with this, this was one of the major PITAs, and made
the AnimationGroup
more complicated than it should have been.

> however, if we feel that the parallel- >sequential switching is not worth it,
> we can simply kill this class and make
> people deal with the slightly unwieldy QAnimationGroup directly. i'm kind of
> leaning in that direction, tbh, even though i dislike parts of
> QAnimationGroup's design.
Now that Animation isA QAbstractAnimation, this makes total sense.
TBH, I don't think we ever came up with a good use case for this. I'll
dig into past emails / my notes and check.

> we still have one large outstanding bit of work left, and that is to port the
> animations away from the use of the previous API revision's "render()" method
> and make them proper QAbstractAnimations. see the Fade animation for how this
> should look if you'd like to pitch in. the ones with render calls still are:
>
>        grow.cpp
>        pause.cpp
>        pulser.cpp
>        rotation.cpp
>        rotationstacked.cpp
>
> Slide should also probably have its internal QPropertyAnimation removed so
> it's as simple/straightforward as Fade is.

Weekend is coming up, I can probably give you guys a hand with this
Friday afternoon / Saturday GMT-5.

Great to see this going in, cheers guys! :)
-- 
~ mali (http://constant.inople.net/)