Review Request: Show shortcut for System Activity in krunner

John Tapsell johnflux at gmail.com
Tue Dec 1 13:12:30 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2308/
-----------------------------------------------------------

(Updated 2009-12-01 12:12:29.713593)


Review request for Plasma.


Summary (updated)
-------

This shows the global shortcut in the tooltip for the System Activity button in the default krunner interface.

It required rearranging the code slightly in krunnerapp so that the interface is created after the shortcuts are created.

NOTE:

This adds the string i18n("%1 (%2)")    but we are currently in string freeze...


Diffs
-----

  trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.h 1056420 
  trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp 1056420 
  trunk/KDE/kdebase/workspace/krunner/krunnerapp.cpp 1056420 

Diff: http://reviewboard.kde.org/r/2308/diff


Testing
-------

Compiled, ran.  Hovered over and saw that the tooltip had changed.  Then went to system settings and changed the shortcut, and saw that the tooltip updated instantly.


Thanks,

John



More information about the Plasma-devel mailing list