Review Request: big revamp of Device Notifier

[Alessandro Diaferia]

2009/8/20 Giulio Camuffo <giuliocamuffo at gmail.com>

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1370/
> -----------------------------------------------------------
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> This is a patch that modifies quite heavily the behaviour of the Device
> Notifier.
> It comes from here:
> http://kde-look.org/content/show.php/Device+Manager?content=106051
> It can show the not removable devices too, it can mount them automatically
> or with a click, since the "eject" button is a "mount" button when the
> volume is umounted. So that guy on the dot will be ok.
> It can hide some items in the same way as Dolphin's places (hide item/ show
> all).
> Finally, it shows the various opening actions under the device instead of
> calling that xp-ish window.
>
>
> Diffs
> -----
>
>  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt
> 1010116
>  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui
> PRE-CREATION
>  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h
> 1010116
>  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp
> 1010116
>  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h
> PRE-CREATION
>  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp
> PRE-CREATION
>  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h
> 1010116
>  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp
> 1010116
>  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h
> 1010116
>  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp
> 1010116
>
> Diff: http://reviewboard.kde.org/r/1370/diff
>
>
> Testing
> -------
>
> I'm using it every day since I released 0.1 on Kde-look. I tried all the
> options on my pc and they work. Some people on kde-look posted some comments
> about some problems, but it seems to me they are very particular cases, so
> in my opinion it is quite stable to go in trunk, but anyway review it! :)
>
>
> Screenshots
> -----------
>
> screen
>  http://reviewboard.kde.org/r/1370/s/183/
>
>
> Thanks,
>
> Giulio
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>


I still didn't review the code but i have 1 question: is the spaceinfo stuff
in the patch from the last revision of the proposed patch for the space info
delegate in reviewboard? With last revision i mean the one i sent to the ml
in the spaceinfo delegate thread. I worked on the last revision of that
patch but i still didn't commit.

Regards

-- 
Alessandro Diaferia
KDE Developer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20090820/22f06d5e/attachment.htm