<br><br><div class="gmail_quote">2009/8/20 Giulio Camuffo <span dir="ltr"><<a href="mailto:giuliocamuffo@gmail.com">giuliocamuffo@gmail.com</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
<a href="http://reviewboard.kde.org/r/1370/" target="_blank">http://reviewboard.kde.org/r/1370/</a><br>
-----------------------------------------------------------<br>
<br>
Review request for Plasma.<br>
<br>
<br>
Summary<br>
-------<br>
<br>
This is a patch that modifies quite heavily the behaviour of the Device Notifier.<br>
It comes from here: <a href="http://kde-look.org/content/show.php/Device+Manager?content=106051" target="_blank">http://kde-look.org/content/show.php/Device+Manager?content=106051</a><br>
It can show the not removable devices too, it can mount them automatically or with a click, since the "eject" button is a "mount" button when the volume is umounted. So that guy on the dot will be ok.<br>
It can hide some items in the same way as Dolphin's places (hide item/ show all).<br>
Finally, it shows the various opening actions under the device instead of calling that xp-ish window.<br>
<br>
<br>
Diffs<br>
-----<br>
<br>
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt 1010116<br>
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui PRE-CREATION<br>
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h 1010116<br>
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp 1010116<br>
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h PRE-CREATION<br>
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp PRE-CREATION<br>
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h 1010116<br>
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp 1010116<br>
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h 1010116<br>
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp 1010116<br>
<br>
Diff: <a href="http://reviewboard.kde.org/r/1370/diff" target="_blank">http://reviewboard.kde.org/r/1370/diff</a><br>
<br>
<br>
Testing<br>
-------<br>
<br>
I'm using it every day since I released 0.1 on Kde-look. I tried all the options on my pc and they work. Some people on kde-look posted some comments about some problems, but it seems to me they are very particular cases, so in my opinion it is quite stable to go in trunk, but anyway review it! :)<br>
<br>
<br>
Screenshots<br>
-----------<br>
<br>
screen<br>
<a href="http://reviewboard.kde.org/r/1370/s/183/" target="_blank">http://reviewboard.kde.org/r/1370/s/183/</a><br>
<br>
<br>
Thanks,<br>
<br>
Giulio<br>
<br>
_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br>
</blockquote></div><br><br clear="all">I still didn't review the code but i have 1 question: is the spaceinfo stuff in the patch from the last revision of the proposed patch for the space info delegate in reviewboard? With last revision i mean the one i sent to the ml in the spaceinfo delegate thread. I worked on the last revision of that patch but i still didn't commit.<br>
<br>Regards<br><br>-- <br>Alessandro Diaferia<br>KDE Developer<br>