Review Request: Simplest Image Hosting support for pastebin applet

[Michal Dutkiewicz]

> On 2009-08-10 16:51:06, Artur de Souza (MoRpHeUz) wrote:
> > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp, line 57
> > <http://reviewboard.kde.org/r/1251/diff/1/?file=9802#file9802line57>
> >
> >     Minor but important: not sure if kdeplasma-addons have coding style guidelines but following kdelibs, "if" statements should have the "{" on the same line :)
> >

Fixed in new diff.

Personally I don't use in my work that coding style (I was using it for some years, but new line is more readable for me and not only me ;-)).

By the way, I could try to rewrite this applet from scratch and add for example support for error messages (SIH returns different error messages for example), that could be passed as signal parameter.


- Michal


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1251/#review1964
-----------------------------------------------------------


On 2009-08-10 16:56:55, Michal Dutkiewicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1251/
> -----------------------------------------------------------
> 
> (Updated 2009-08-10 16:56:55)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch adds support for Simplest Image Hosting (http://simplest-image-hosting.net/) to pastebin applet.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui 1008396 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp PRE-CREATION 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1251/diff
> 
> 
> Testing
> -------
> 
> Works fine except showing error icon even if upload is successful (there is success notification and link is added to history).
> 
> 
> Thanks,
> 
> Michal
> 
>