Review Request: adds private imagebin to the pastebin plasmoid This is my first patch, it just adds "posting private picture to imagebin.ca from the pastebin plasmoid" as the title says, it needs to be applied from kdeplasma-addons, hope it works for you.

[patcito at gmail.com]

> On 2009-08-09 20:59:45, Chani wrote:
> > hmm. I just noticed it's only for imagebin.ca not imageshack.us - are you able to make it work for both servers? :) (if you can, then let's use the same config option, i don't see any reason to make users set image privacy twice.)

I may be wrong but I think that on imageshack.us all pictures are private, they don't appear on the front page, you actually have to know the URL (which is the same as the private option for imagebin.ca).


> On 2009-08-09 20:59:45, Chani wrote:
> > /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt, line 3
> > <http://reviewboard.kde.org/r/1248/diff/1/?file=9780#file9780line3>
> >
> >     not sure what this is doing here. slipped in by accident?

I was trying to compile from that directory at first so I added that, I'll remove it.


> On 2009-08-09 20:59:45, Chani wrote:
> > /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt, line 16
> > <http://reviewboard.kde.org/r/1248/diff/1/?file=9780#file9780line16>
> >
> >     ehh... I still feel like the config could go on the main page.

Ok, I'll move it there.


> On 2009-08-09 20:59:45, Chani wrote:
> > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.cpp, line 38
> > <http://reviewboard.kde.org/r/1248/diff/1/?file=9782#file9782line38>
> >
> >     0 not "0"

Fixing.


> On 2009-08-09 20:59:45, Chani wrote:
> > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp, line 471
> > <http://reviewboard.kde.org/r/1248/diff/1/?file=9784#file9784line471>
> >
> >     use 0 not "0" so that it doesn't have to convert from a string

Fixing too.


- patcito


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1248/#review1940
-----------------------------------------------------------


On 2009-08-09 20:13:23, patcito wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1248/
> -----------------------------------------------------------
> 
> (Updated 2009-08-09 20:13:23)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This is my first patch, it just adds "posting private picture to
> imagebin.ca from the pastebin plasmoid" as the title says, it needs to
> be applied from kdeplasma-addons, hope it works for you.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008583 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.h 1008583 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.cpp 1008583 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008583 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008583 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersOptionsConfig.ui PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1248/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> servers options config
>   http://reviewboard.kde.org/r/1248/s/168/
> 
> 
> Thanks,
> 
> patcito
> 
>