Review Request: adds private imagebin to the pastebin plasmoid This is my first patch, it just adds "posting private picture to imagebin.ca from the pastebin plasmoid" as the title says, it needs to be applied from kdeplasma-addons, hope it works for you.

[Chani]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1248/#review1940
-----------------------------------------------------------

Ship it!


hmm. I just noticed it's only for imagebin.ca not imageshack.us - are you able to make it work for both servers? :) (if you can, then let's use the same config option, i don't see any reason to make users set image privacy twice.)


/trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt
<http://reviewboard.kde.org/r/1248/#comment1289>

    not sure what this is doing here. slipped in by accident?



/trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt
<http://reviewboard.kde.org/r/1248/#comment1293>

    ehh... I still feel like the config could go on the main page.



/trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.cpp
<http://reviewboard.kde.org/r/1248/#comment1288>

    0 not "0"



/trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp
<http://reviewboard.kde.org/r/1248/#comment1287>

    use 0 not "0" so that it doesn't have to convert from a string



/trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp
<http://reviewboard.kde.org/r/1248/#comment1294>

    "Server Options" :)


- Chani


On 2009-08-09 20:13:23, patcito wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1248/
> -----------------------------------------------------------
> 
> (Updated 2009-08-09 20:13:23)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This is my first patch, it just adds "posting private picture to
> imagebin.ca from the pastebin plasmoid" as the title says, it needs to
> be applied from kdeplasma-addons, hope it works for you.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008583 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.h 1008583 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.cpp 1008583 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008583 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008583 
>   /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersOptionsConfig.ui PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1248/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> servers options config
>   http://reviewboard.kde.org/r/1248/s/168/
> 
> 
> Thanks,
> 
> patcito
> 
>