Review Request: Ported kopete systray icon to KNotificationAreaItem.

[Marco Martin]

On Saturday 25 April 2009, Aaron Seigo wrote:
> > On 2009-04-18 06:14:05, Marco Martin wrote:
> > > with the premise that i don't know kopete enough, it seems good to me
> > > and seems to work quite good. tough it opens two questions:
> > > -hiding: should be a function in the api to hide the icon? (i would say
> > > if you want to completely remove the icon, delete the
> > > knotificationareaitem instance, but seems tricky in this kopete
> > > example..)
> > >
> > > -overlays: many apps, like kopete here seems to use composite icons to
> > > show status, overlays and things like that, so of course they all have
> > > to fallback at the pixmap method.. could be provided some facility in
> > > the protocol (i.e setOverlayIcon) or (as i propend now) anyways eveyone
> > > will want to do -slightly- different so in the end pixmaps will be used
> > > anyways?
>
> while it complicates the spec, i think it will simplify things for apps and
> allow for greater conistency. so yes, i think that overlay icons would be a
> nice addition.
will give a try
>
> as for hiding ... shouldn't it just set the status of the icon
> appropriately and then the tray can decide to hide it? :)
agree, i would say: 
99% of the times, just set as passive, when the app really really don't want 
it, don't instantiate a knotificationitem or delete it.
>
>
> - Aaron
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/603/#review955
> -----------------------------------------------------------
>
> On 2009-04-17 15:06:26, Davide Bettio wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/603/
> > -----------------------------------------------------------
> >
> > (Updated 2009-04-17 15:06:26)
> >
> >
> > Review request for Kopete and Plasma.
> >
> >
> > Summary
> > -------
> >
> > Ported kopete systray icon to KNotificationAreaItem.
> >
> >
> > Diffs
> > -----
> >
> >   /trunk/KDE/kdenetwork/kopete/kopete/CMakeLists.txt 955509
> >   /trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.cpp 955509
> >   /trunk/KDE/kdenetwork/kopete/kopete/systemtray.h 955509
> >   /trunk/KDE/kdenetwork/kopete/kopete/systemtray.cpp 955509
> >
> > Diff: http://reviewboard.kde.org/r/603/diff
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Davide