Review Request: Ported kopete systray icon to KNotificationAreaItem.

[Matt Rogers]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/603/#review989
-----------------------------------------------------------


You haven't put that you've done any testing with this. I'd like to see this get some actual testing by the submitted before approval.


/trunk/KDE/kdenetwork/kopete/kopete/systemtray.cpp
<http://reviewboard.kde.org/r/603/#comment669>

    this change seems unrelated to the actual port to KNotificationAreaItem



/trunk/KDE/kdenetwork/kopete/kopete/systemtray.cpp
<http://reviewboard.kde.org/r/603/#comment670>

    fix the trailing whitespace



/trunk/KDE/kdenetwork/kopete/kopete/systemtray.cpp
<http://reviewboard.kde.org/r/603/#comment671>

    Why QIcon here?


- Matt


On 2009-04-17 15:06:26, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/603/
> -----------------------------------------------------------
> 
> (Updated 2009-04-17 15:06:26)
> 
> 
> Review request for Kopete and Plasma.
> 
> 
> Summary
> -------
> 
> Ported kopete systray icon to KNotificationAreaItem.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdenetwork/kopete/kopete/CMakeLists.txt 955509 
>   /trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.cpp 955509 
>   /trunk/KDE/kdenetwork/kopete/kopete/systemtray.h 955509 
>   /trunk/KDE/kdenetwork/kopete/kopete/systemtray.cpp 955509 
> 
> Diff: http://reviewboard.kde.org/r/603/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Davide
> 
>