Review Request: Use libplasmaweather in Weather Wallpaper

[Jonathan Thomas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/589/#review922
-----------------------------------------------------------

Ship it!


Ooh, looks great! This port is greatly appreciated. Before, setting a new location after you set the first one didn't work at all. Now it works, unless you set a different location, then try to go back to your old location. (E.G. Set to manchester, new hampshire -> Hit OK (everything works), set it to a different location (say, San Francisco, California) -> hit OK (everything still works). But then, trying to go back to manchester, the wallpaper still stays at the one for San Francisco. This is, however, better than it used to be by far. :)

Also, I assume later that I can manually add a button to WeatherConfig's layout so that I can reach the advanced setting for the wallpaper, correct?

Thanks again!

- Jonathan


On 2009-04-14 14:28:46, Petri Damstén wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/589/
> -----------------------------------------------------------
> 
> (Updated 2009-04-14 14:28:46)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Use libplasmaweather WeatherConfig widget in Weather Wallpaper.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/wallpapers/weather/CMakeLists.txt 953924 
>   /trunk/KDE/kdeplasma-addons/wallpapers/weather/weatherAddPlace.ui 953924 
>   /trunk/KDE/kdeplasma-addons/wallpapers/weather/weatherLocations.ui 953924 
>   /trunk/KDE/kdeplasma-addons/wallpapers/weather/weatherwallpaper.h 953924 
>   /trunk/KDE/kdeplasma-addons/wallpapers/weather/weatherwallpaper.cpp 953924 
> 
> Diff: http://reviewboard.kde.org/r/589/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Petri
> 
>