Review Request: Use libplasmaweather in Weather Wallpaper

[Andrew Coles]

Nice work - it's good to see how many LOC one can save with libplasmaweather.  Two questions:

 i) Geolocation is compulsary, so if it uses IP localisation I'll get the weather for 200 miles away.  A manual override would be useful (i.e. the old behaviour).

ii) The GPS geolocation backend doesn't return a city name, only lat/long data.  Can libplasmaweather still get a weather report in this case?  I know the geonames service will do it*, but is this configured as a weather source?

Andrew


* http://ws.geonames.org/findNearByWeatherXML?lat=43&lng=-2


----- Original Message ----
From: Petri Damstén <petri.damsten at gmail.com>
To: Petri Damstén <petri.damsten at gmail.com>; Plasma <plasma-devel at kde.org>
Sent: Tuesday, 14 April, 2009 22:28:46
Subject: Re: Review Request: Use libplasmaweather in Weather Wallpaper


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/589/
-----------------------------------------------------------

(Updated 2009-04-14 14:28:46.261240)


Review request for Plasma.


Changes
-------

Get initial place using geolocation dataengine.


Summary
-------

Use libplasmaweather WeatherConfig widget in Weather Wallpaper.


Diffs (updated)
-----

  /trunk/KDE/kdeplasma-addons/wallpapers/weather/CMakeLists.txt 953924 
  /trunk/KDE/kdeplasma-addons/wallpapers/weather/weatherAddPlace.ui 953924 
  /trunk/KDE/kdeplasma-addons/wallpapers/weather/weatherLocations.ui 953924 
  /trunk/KDE/kdeplasma-addons/wallpapers/weather/weatherwallpaper.h 953924 
  /trunk/KDE/kdeplasma-addons/wallpapers/weather/weatherwallpaper.cpp 953924 

Diff: http://reviewboard.kde.org/r/589/diff


Testing
-------


Thanks,

Petri

_______________________________________________
Plasma-devel mailing list
Plasma-devel at kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel