Review Request: Prevent Plasma popups from showing over screensaver

[J. Janz]

> On 2009-04-14 08:58:10, Aaron Seigo wrote:
> > unfortunately, this breaks "passive" mode: if you click on a notification and then click off it, it goes away. ok, minor annoyance, right? open the clock ... the calendar pops up and then goes away as soon as you click back onto the document you were working on in the first place. we may need some event handling in the passive case to reject closes due to loss of focus.

Sorry if I'm ignorant about this but, speaking as a user ... Isn't it a desired behaviour? It's a thing I'd bring to plasma-devel as no popup was closing when losing focus (calendar from clock, recent devices from device notifier, kickoff etc). I don't see a reason for them (any of the popups I use or can think of) to be kept open after used.


- J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/546/#review916
-----------------------------------------------------------


On 2009-04-14 13:17:59, Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/546/
> -----------------------------------------------------------
> 
> (Updated 2009-04-14 13:17:59)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Use Qt::Tool window flag to prevent passive Plasma popups from showing over screensaver.
> 
> 
> This addresses bug 179924.
>     https://bugs.kde.org/show_bug.cgi?id=179924
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/popupapplet.cpp 951469 
>   /trunk/KDE/kdelibs/plasma/private/popupapplet_p.h 951469 
> 
> Diff: http://reviewboard.kde.org/r/546/diff
> 
> 
> Testing
> -------
> 
> Tested passive popup with battery notifications.
> Checked that KDE menu correctly gets keyboard focus when opened.
> 
> 
> Thanks,
> 
> Aurélien
> 
>