Review Request: Prevent Plasma popups from showing over screensaver

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/546/
-----------------------------------------------------------

(Updated 2009-04-14 13:17:59.288730)


Review request for Plasma.


Changes
-------

Fix for passive popup disappearing when they are deactivated. Since PopupApplet installs an event filter to make the popup disappear, just don't do anything when the popup is passive.


Summary
-------

Use Qt::Tool window flag to prevent passive Plasma popups from showing over screensaver.


This addresses bug 179924.
    https://bugs.kde.org/show_bug.cgi?id=179924


Diffs (updated)
-----

  /trunk/KDE/kdelibs/plasma/popupapplet.cpp 951469 
  /trunk/KDE/kdelibs/plasma/private/popupapplet_p.h 951469 

Diff: http://reviewboard.kde.org/r/546/diff


Testing
-------

Tested passive popup with battery notifications.
Checked that KDE menu correctly gets keyboard focus when opened.


Thanks,

Aurélien