Review Request: Prevent Plasma popups from showing over screensaver

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/546/
-----------------------------------------------------------

(Updated 2009-04-14 07:48:09.451730)


Review request for Plasma.


Changes
-------

After some more testing, it turns out Qt::X11BypassWindowManagerHint does not play well with the screensaver. Disabling it fix the problem.

I also added the Qt::WA_X11NetWmWindowTypeNotification flag, because I believe it makes sense and is the equivalent of what the Gnome notifications do (and they do not show over the screensaver).


Summary
-------

Use Qt::Tool window flag to prevent passive Plasma popups from showing over screensaver.


This addresses bug 179924.
    https://bugs.kde.org/show_bug.cgi?id=179924


Diffs (updated)
-----

  /trunk/KDE/kdelibs/plasma/popupapplet.cpp 951469 
  /trunk/KDE/kdelibs/plasma/private/popupapplet_p.h 951469 

Diff: http://reviewboard.kde.org/r/546/diff


Testing
-------

Tested passive popup with battery notifications.
Checked that KDE menu correctly gets keyboard focus when opened.


Thanks,

Aurélien