Review Request: Much less flickering when there is no backing store

[David Nolden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/488/
-----------------------------------------------------------

(Updated 2009-04-13 04:48:24.908532)


Review request for Plasma.


Changes
-------

Solve the problem also for the X11 data engine. The pixmap needs to be copied first, else we get a crash, and then it needs to be converted to a QImage, so a comparison can happen.

Btw. the flickering problem also appears with backing store enabled, only with composition disabled. I didn't test with composition, but now I guess it also happens with composition enabled.


Summary
-------

Remember the background image used for the tray-icon, and do not update it if it has not changed.

The following XClearArea call leads to a very annoying flicker when the backing-store is disabled, and to the user, it happens at totally random occasions.

Unfortunately this can only be implemented cheaply for the raster engine, since there does not seem to be an efficient way to compare QPixmap's. 


Diffs (updated)
-----

  trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedcontainer.cpp 951629 
  trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.h 951629 
  trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp 951629 
  trunk/KDE/kdebase/workspace/plasma/dataengines/CMakeLists.txt 951629 
  trunk/KDE/kdebase/workspace/plasma/shells/CMakeLists.txt 951629 
  trunk/KDE/kdebase/workspace/plasma/shells/desktop/desktopview.h 951629 
  trunk/KDE/kdebase/workspace/plasma/shells/desktop/desktopview.cpp 951629 
  trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelview.h 951629 
  trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelview.cpp 951629 
  trunk/KDE/kdebase/workspace/plasma/shells/desktop/plasmaapp.h 951629 
  trunk/KDE/kdebase/workspace/plasma/shells/desktop/plasmaapp.cpp 951629 

Diff: http://reviewboard.kde.org/r/488/diff


Testing
-------


Thanks,

David