Review Request: Much less flickering when there is no backing store

[David Nolden]

> On 2009-03-31 17:49:41, Aaron Seigo wrote:
> > perhaps Qt::HANDLE QPixmap::x11PictureHandle() const would work for comparing the pixmaps?

In each pass, the pixmaps are created newly using deep copies, by QPixmap::copyRect(..), so I fear the identity is different every time(I already checked QPixmap::cacheKey()). Ah yeah, the basic pixmap they are copied from is also different every time. :)

My hope was that there might be some XRender function or something like that, but I haven't found any.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/488/#review766
-----------------------------------------------------------


On 2009-03-31 17:11:55, David Nolden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/488/
> -----------------------------------------------------------
> 
> (Updated 2009-03-31 17:11:55)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Remember the background image used for the tray-icon, and do not update it if it has not changed.
> 
> The following XClearArea call leads to a very annoying flicker when the backing-store is disabled, and to the user, it happens at totally random occasions.
> 
> Unfortunately this can only be implemented cheaply for the raster engine, since there does not seem to be an efficient way to compare QPixmap's. 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedcontainer.cpp 940781 
> 
> Diff: http://reviewboard.kde.org/r/488/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David
> 
>