Review Request: Add keyboard navigation to plasma applet Folder View

[Shantanu Tushar Jha]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/
-----------------------------------------------------------

(Updated 2009-04-02 13:21:02.238361)


Review request for Plasma.


Changes
-------

Its ok, I figured it out why was !nextIndex.isValid() required and have updated the Diff accordingly. Please check it and see if there are any issues and if this is ok to commit ...


Summary
-------

This partly addresses the above bug, adding keyboard navigation and launch using Enter key.
Please report if the code is too complex, I've tried my best to keep it to the point.


This addresses bug 187241.
    https://bugs.kde.org/show_bug.cgi?id=187241


Diffs (updated)
-----

  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 948236 
  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 948236 

Diff: http://reviewboard.kde.org/r/368/diff


Testing
-------

Tested on latest SVN build. Navigation and launch work fine. The problem is with movement of the scrollbar with the keyboard focus, the scrollbar refuses to go to minimum value when m_scrollBar->setValue( m_scrollBar->minimum() ); is used. What am I doing wrong?


Thanks,

Shantanu