Review Request: Add keyboard navigation to plasma applet Folder View

Shantanu Tushar Jha jhahoneyk at gmail.com
Thu Apr 2 17:55:50 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/
-----------------------------------------------------------

(Updated 2009-04-02 08:55:49.469863)


Review request for Plasma.


Changes
-------

Provided support for keyboard navigation even if the user has made the view unsorted. Please try it out and report any issues that you may encounter. I've tried to adhere with the kdelibs coding style, hope its all right. :)


Summary
-------

This partly addresses the above bug, adding keyboard navigation and launch using Enter key.
Please report if the code is too complex, I've tried my best to keep it to the point.


This addresses bug 187241.
    https://bugs.kde.org/show_bug.cgi?id=187241


Diffs (updated)
-----

  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 947761 
  /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 947761 

Diff: http://reviewboard.kde.org/r/368/diff


Testing
-------

Tested on latest SVN build. Navigation and launch work fine. The problem is with movement of the scrollbar with the keyboard focus, the scrollbar refuses to go to minimum value when m_scrollBar->setValue( m_scrollBar->minimum() ); is used. What am I doing wrong?


Thanks,

Shantanu



More information about the Plasma-devel mailing list