Review Request: theme-dependent icons for applethandle

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/192/
-----------------------------------------------------------

(Updated 2008-09-15 09:34:32.062407)


Review request for Plasma.


Summary
-------

this is an idea was discussed a big while ago in the mailing list http://mail.kde.org/pipermail/plasma-devel/2008-July/000019.html
and then i forgot i actually wanted to implement the thing, my bad :P
it gives the applet handle proper control icons (idea being monocromatic, as in mockups, btw the current graphics is just a stub)
these little icons then could be used in other contexts as well
they are now in png, because at that time we decided to use png to have less overhead.
there should be decided sane names (btw i would keep the svgs somewhere don't know if in the same folder or somewhere else just to "have the source")

update: now it uses svgs, one file for each icon because i think it's easier to expand for the "fallback" problem i talked above.
also the resize icon is different if the handle is at the left or at the right, so the diagonal arrow always makes sense


Diffs
-----

  /trunk/KDE/kdebase/workspace/libs/plasma/private/applethandle.cpp
  /trunk/KDE/kdebase/workspace/libs/plasma/private/applethandle_p.h
  /trunk/KDE/kdebase/workspace/plasma/desktoptheme/CMakeLists.txt
  /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/close.png
  /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/close.svgz
  /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/configure.png
  /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/configure.svgz
  /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/move.png
  /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/move.svgz
  /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/size-diag-tl2br.svgz
  /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/size-diag-tr2bl.svgz
  /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/size-hor.svgz
  /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/size-ver.png
  /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/size-ver.svgz
  /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/size_diag-tl2br.svg.png
  /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/size_diag-tr2bl.png
  /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/size_hor.png
  /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/transform-rotate.png
  /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/transform-rotate.svgz

Diff: http://reviewboard.vidsolbach.de/r/192/diff


Testing
-------


Screenshots
-----------


  http://reviewboard.vidsolbach.de/r/192/s/62/


Thanks,

Marco