Review Request: HTML plasmoids

[Petri Damstén]

> On 2008-09-14 13:38:39, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/plasmawebapplet.cpp, line 318
> > <http://reviewboard.vidsolbach.de/r/191/diff/1/?file=982#file982line318>
> >
> >     any particular reason this could just return a QSize?

QSize, QSizeF, QRectF, etc. return typeof == "string" in javascript (qt webkit does not convert those?). QVariantList can be handled as an array.


- Petri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/191/#review193
-----------------------------------------------------------


On 2008-09-14 09:07:27, Petri Damstén wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/191/
> -----------------------------------------------------------
> 
> (Updated 2008-09-14 09:07:27)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Adds webkit package format and more complete plasma api to html widgets.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/CMakeLists.txt
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/bundle.cpp
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/dashboardapplet.h
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/dashboardapplet.cpp
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/plasma-packagestructure-web.desktop
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/plasma-scriptengine-applet-web.desktop
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/plasmajs.h
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/plasmajs.cpp
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/plasmawebapplet.h
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/plasmawebapplet.cpp
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/webapplet.h
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/webapplet.cpp
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/webapplet_package.h
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/webapplet_package.cpp
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/webapplet_plugin.cpp
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/webpage.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/191/diff
> 
> 
> Testing
> -------
> 
> It runs the html test applet here:
> http://kotisivu.lumonetti.fi/damu0/kde/html_test.zip
> http://kotisivu.lumonetti.fi/damu0/kde/screenshot.jpeg
> 
> I'm going to make couple of 'real' applets to get more testing.
> 
> 
> Thanks,
> 
> Petri
> 
>