Review Request: HTML plasmoids

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/191/#review193
-----------------------------------------------------------

Ship it!


some small comments, but in general i think this is ready to go



/trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/bundle.cpp
<http://reviewboard.vidsolbach.de/r/191/#comment157>

    the parent at least should be passed up to the PackageStrucdture ctor



/trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/plasmawebapplet.cpp
<http://reviewboard.vidsolbach.de/r/191/#comment158>

    this seems a bit fragile .. it would be good if it was generated based on the actual values in plasma.h, otherwise we have to keep them in sync by hand. 



/trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/plasmawebapplet.cpp
<http://reviewboard.vidsolbach.de/r/191/#comment159>

    any particular reason this could just return a QSize?



/trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/webapplet.cpp
<http://reviewboard.vidsolbach.de/r/191/#comment161>

    some comments should be added to this method explaining the difference here between the two types of widgets (os x dashboard and plasma) ...
    
    *or* we coul add a "root" item to the os dashboard package and change "webpage" to "mainscript" in dashboard and then we don't have to differentiate!



/trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/webapplet.cpp
<http://reviewboard.vidsolbach.de/r/191/#comment160>

    a nice pattern to follow is sth like:
    
    QString webpage = package()->filePath("webpage");
    
    if (webpage.isEmpty()) {
        // the fallback
        webpage = package()->filePath("mainscript"); // plasma web applet
    }
    
    filePath is only called once in the best case, and twice in the worse, versus 2 times no matter what.


- Aaron


On 2008-09-14 09:07:27, Petri Damstén wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/191/
> -----------------------------------------------------------
> 
> (Updated 2008-09-14 09:07:27)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Adds webkit package format and more complete plasma api to html widgets.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/CMakeLists.txt
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/bundle.cpp
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/dashboardapplet.h
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/dashboardapplet.cpp
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/plasma-packagestructure-web.desktop
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/plasma-scriptengine-applet-web.desktop
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/plasmajs.h
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/plasmajs.cpp
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/plasmawebapplet.h
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/plasmawebapplet.cpp
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/webapplet.h
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/webapplet.cpp
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/webapplet_package.h
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/webapplet_package.cpp
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/webapplet_plugin.cpp
>   /trunk/KDE/kdebase/workspace/plasma/scriptengines/webkit/webpage.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/191/diff
> 
> 
> Testing
> -------
> 
> It runs the html test applet here:
> http://kotisivu.lumonetti.fi/damu0/kde/html_test.zip
> http://kotisivu.lumonetti.fi/damu0/kde/screenshot.jpeg
> 
> I'm going to make couple of 'real' applets to get more testing.
> 
> 
> Thanks,
> 
> Petri
> 
>