Review Request: theme-dependent icons for applethandle

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/192/#review194
-----------------------------------------------------------


that looks so much better!

as for supporting png's in the theme .. that's perhaps an ok idea .. but i'd prefer to avoid adding another path check for them. could we just put all these icons into one svg file?

that way all the icons related to the theme would end up in one file that would be managed by a renderer shared by all users of these icons.

the overhead should be low: one svg object, still all bitmaps.

or ... we could just make them svg's in the icons file as well i guess ... see how that goes... they should get rendered just once into pixmaps at runtime, and they look like pretty simples shapes.

in any case, i'm generally in favour of this change!

- Aaron


On 2008-09-14 10:49:28, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/192/
> -----------------------------------------------------------
> 
> (Updated 2008-09-14 10:49:28)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this is an idea was discussed a big while ago in the mailing list http://mail.kde.org/pipermail/plasma-devel/2008-July/000019.html
> and then i forgot i actually wanted to implement the thing, my bad :P
> it gives the applet handle proper control icons (idea being monocromatic, as in mockups, btw the current graphics is just a stub)
> these little icons then could be used in other contexts as well
> they are now in png, because at that time we decided to use png to have less overhead.
> there should be decided sane names (btw i would keep the svgs somewhere don't know if in the same folder or somewhere else just to "have the source")
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/private/applethandle.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/theme.cpp
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/CMakeLists.txt
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/close.png
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/close.svgz
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/configure.png
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/configure.svgz
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/move.png
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/move.svg
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/size-ver.png
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/size_diag-tl2br.svg
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/size_diag-tl2br.svg.png
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/size_diag-tr2bl.png
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/size_diag-tr2bl.svg
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/size_hor.png
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/size_hor.svg
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/size_ver.svg
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/transform-rotate.png
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/icons/transform-rotate.svgz
> 
> Diff: http://reviewboard.vidsolbach.de/r/192/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://reviewboard.vidsolbach.de/r/192/s/62/
> 
> 
> Thanks,
> 
> Marco
> 
>