Review Request: Plasma::Dialog resizeRegion() added

[Alessandro Diaferia]

> On 2008-09-12 08:11:10, Aaron Seigo wrote:
> > instead of returning a region that is used by resize areas .. what about a method that takes a point and returns a boolean on whether or not that point is in a control area of the dialog? this way it isn't biased towards resizing (we might add other features in the future) and we can avoid creating and testing with regions which often aren't the fastest things in the world.

trying to follow your suggestion i updated the patch.. does it look good? =)


- Alessandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/181/#review190
-----------------------------------------------------------


On 2008-09-12 09:27:19, Alessandro Diaferia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/181/
> -----------------------------------------------------------
> 
> (Updated 2008-09-12 09:27:19)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> I reimplemented mouse events of Plasma::Dialog for my Previewer applet to allow users move the dialog here and there on the screen. Since the dialog is also resizable i need to know which part of the Plasma::Dialog are supposed to catch mouse events in order to avoid movement even when the user just wants to resize the dialog. Because of this i added this small function to Plasma::Dialog. Please tell me if it is ok to commit.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/dialog.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/181/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alessandro
> 
>