Review Request: Plasma::Dialog resizeRegion() added

[Alessandro Diaferia]

2008/9/12 Aaron Seigo <aseigo at kde.org>

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/181/#review190
> -----------------------------------------------------------
>
>
> instead of returning a region that is used by resize areas .. what about a
> method that takes a point and returns a boolean on whether or not that point
> is in a control area of the dialog? this way it isn't biased towards
> resizing (we might add other features in the future) and we can avoid
> creating and testing with regions which often aren't the fastest things in
> the world.


I totally agree with you :P
But.. can you suggest me a nice name for this method? maybe bool
inControlArea(const QPoint &) ?

>
>
> - Aaron
>
>
> On 2008-09-09 05:17:19, Alessandro Diaferia wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.vidsolbach.de/r/181/
> > -----------------------------------------------------------
> >
> > (Updated 2008-09-09 05:17:19)
> >
> >
> > Review request for Plasma.
> >
> >
> > Summary
> > -------
> >
> > I reimplemented mouse events of Plasma::Dialog for my Previewer applet to
> allow users move the dialog here and there on the screen. Since the dialog
> is also resizable i need to know which part of the Plasma::Dialog are
> supposed to catch mouse events in order to avoid movement even when the user
> just wants to resize the dialog. Because of this i added this small function
> to Plasma::Dialog. Please tell me if it is ok to commit.
> >
> >
> > Diffs
> > -----
> >
> >   trunk/KDE/kdebase/workspace/libs/plasma/dialog.h
> >   trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp
> >
> > Diff: http://reviewboard.vidsolbach.de/r/181/diff
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Alessandro
> >
> >
>
>

Regards
-- 
Alessandro Diaferia
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20080912/be9627e9/attachment-0001.htm