Review Request: icon-less popupapplets and popupappletified clock

Sebastian Kügler sebas at kde.org
Fri Sep 12 15:58:17 CEST 2008


On Tuesday 09 September 2008 21:46:52 Marco Martin wrote:
> the patch on popupapplet is derived from the aaron's one
> and the clock uses it
> thing that i noted: icon() badly clash with Applet::icon() (that's even not
> virtual) it's really not the same thing, should have a different name
> perhaps?

I've applied the patch and ported the battery to make use of it. 
Unfortunately, it breaks the battery: its contensRect->size() becomes 0,0. 
I've attached the patch to the battery that causes this behaviour for me, 
maybe I'm doing something wrong ...
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: battery-popup-zerosize.diff
Type: text/x-patch
Size: 2445 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20080912/fb302a95/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 481 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20080912/fb302a95/attachment.sig 


More information about the Plasma-devel mailing list