TaskManager::windowChangedGeometry() displacable?

christian mollekopf chrigi_1 at hotmail.com
Mon Oct 27 22:35:47 CET 2008


I noticed in 
void TaskManager::windowChanged(WId w, unsigned int dirty) 
the windowChangedGeometry(t) signal isn't neccessary anymore and we can easely switch to the
windowChanged(changes)  signal.

Should i change this or is this on purpose?


This is the questionable code.


  TaskChanges changes = TaskUnchanged;

    //kDebug() << "got changes, but will we refresh?" << dirty;
    if (dirty) {
        // only refresh this stuff if we have other changes besides icons
        changes = t->refresh(dirty);
    }

    if (changes & GeometryChanged) {
        changes ^= GeometryChanged;
        emit windowChangedGeometry(t);
    }

    if (changes != TaskUnchanged) {
        emit windowChanged(t, changes);
    }
}


Regards,

Christian
_________________________________________________________________
Die neue Generation der Windows Live Services - jetzt downloaden!
http://get.live.com


More information about the Plasma-devel mailing list