Review Request: new meter theming approach

[Marco Martin]

On Friday 24 October 2008, Rob Scheepmaker wrote:
> On Friday 24 October 2008 12:24:03 Marco Martin wrote:
> > > On 2008-10-23 23:19:59, Petri Damstén wrote:
> > > > /trunk/KDE/kdebase/workspace/libs/plasma/widgets/meter.cpp, line 122
> > > > <http://reviewboard.vidsolbach.de/r/239/diff/1/?file=1278#file1278lin
> > > >e1 22>
> > > >
> > > >     * Fixed tile width/height ratio?
> >
> > yeah, kinda, since panelsvg does not really have "natural sizes" since is
> > not an element but a collection of them the idea is to make tiles near to
> > golden ratio, but sligthly modified to fit an integer number of them,
> > it's still not perfect because sometimes the margin is too much anyways,
> > better ideas?
>
> What if you add an element to the svg which indicates the tiles 'natural'
> height/weight ratio. The golden ratio is a good start, but I think themes
> should be able to customize this number.
yes, can be an idea, i wanted to not get the svg file too complex, but an 
additional hint could be necessary...
or maybe using the proportion of the center element of the active tile item, 
would be clear enough?

Cheers,
Marco Martin

> Looks good otherwise.
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel