Review Request: new meter theming approach

[Rob Scheepmaker]

On Friday 24 October 2008 12:24:03 Marco Martin wrote:
> > On 2008-10-23 23:19:59, Petri Damstén wrote:
> > > /trunk/KDE/kdebase/workspace/libs/plasma/widgets/meter.cpp, line 122
> > > <http://reviewboard.vidsolbach.de/r/239/diff/1/?file=1278#file1278line1
> > >22>
> > >
> > >     * Fixed tile width/height ratio?
>
> yeah, kinda, since panelsvg does not really have "natural sizes" since is
> not an element but a collection of them the idea is to make tiles near to
> golden ratio, but sligthly modified to fit an integer number of them, it's
> still not perfect because sometimes the margin is too much anyways, better
> ideas?

What if you add an element to the svg which indicates the tiles 'natural' 
height/weight ratio. The golden ratio is a good start, but I think themes 
should be able to customize this number.

Looks good otherwise.