Review Request: just show an icon as configoverlay for popupapplets in panel

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/277/#review270
-----------------------------------------------------------



/trunk/KDE/kdelibs/plasma/applet.cpp
<http://reviewboard.vidsolbach.de/r/277/#comment218>

    should this be done for all applets? i'd rather see consistency here, tbh.. and the icon vs button makes sense in the constrained situation .. assuming the size is is actually small =)


- Aaron


On 2008-11-22 13:58:01, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/277/
> -----------------------------------------------------------
> 
> (Updated 2008-11-22 13:58:01)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> some applets like twitter have an overlay and a config button over them.
> but if a popupapplet has this configuration required the config button is in the panel, so it's too large for the icon and exits from the layout.
> this patch makes it a plasma icon with the usual config icon in that case, not sure about putting a so specialized case but looks way better
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/applet.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/277/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>