Review Request: [Pager] Toggle the desktop when you clik on the current desktop

[Loic Marteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/275/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Hey all !

I would like to have yours opinions with that small patch who enable the user to toggle the desktop when he click on the current desktop on it.

What perhaps I can start to say on it:
- dont need to waste more pixels by using show desktop
- not very discoverable
- can confuse the first time he use it but is useful when he understand the behaviour ?!

About this i have first started this by using the dashboard instead of the desktop but this dont permit to toggle since the panel is not in the dashboard, so i think than in this case showing the desktop make more sens)

If you think the non discoverability of this is a stopper perhaps we can add an option not checked by default :
- "toggle the Desktop when you click on the active one".

So we wait in this case for 4.3 and string unfreeze, but perhaps even with no new string we have to wait the feature one too ?
Not sure this can be really called a complete "feature" but more an adjustement of the pager behaviour

Cheers

Lo


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/applets/pager/pager.h
  /trunk/KDE/kdebase/workspace/plasma/applets/pager/pager.cpp

Diff: http://reviewboard.vidsolbach.de/r/275/diff


Testing
-------


Thanks,

Loic