Review Request: Bug with Plasma::Delegate text painter
Jesse Zamora
xtremek2008 at aim.com
Wed Nov 19 22:49:28 CET 2008
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/274/
-----------------------------------------------------------
(Updated 2008-11-19 13:49:28.145433)
Review request for Plasma.
Summary
-------
I have fixed the bug in Plasma::Delegate (in the screenshot) where long strings run out of the item rects and make it look ugly. Please review this patch and tell me if there's anything I can do to make it better.
Xtreme Kommander
P.S. Does anyone know how I may check the text orientation? If a language has right-to-left text orientation, then this patch wouldn't work too well....
Diffs
-----
/trunk/KDE/kdelibs/plasma/delegate.cpp
Diff: http://reviewboard.vidsolbach.de/r/274/diff
Testing
-------
Screenshots
-----------
Plasma delegate text painting bug
http://reviewboard.vidsolbach.de/r/274/s/94/
Fixed bug in Plasma::Delegate
http://reviewboard.vidsolbach.de/r/274/s/95/
Thanks,
Jesse
More information about the Plasma-devel
mailing list