Review Request: discard cache on theme update
Aaron Seigo
aseigo at kde.org
Sun Nov 9 20:59:37 CET 2008
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/265/#review259
-----------------------------------------------------------
Ship it!
this is good imo. we can even force updates this way by up'ing a version number in the metadata file, for instance. =)
- Aaron
On 2008-11-09 05:15:14, Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/265/
> -----------------------------------------------------------
>
> (Updated 2008-11-09 05:15:14)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> This micro patch make expire the pixmapcache on theme loading and deletes the sizes config file when the desktop file of the theme has a modification time more recent than the cache timestamp
> basing on that file won't produce perfect results but doing more in detail could make waay too many disk access perhaps
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/plasma/theme.cpp
>
> Diff: http://reviewboard.vidsolbach.de/r/265/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco
>
>
More information about the Plasma-devel
mailing list