Review Request: per-applet authors' info!

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/263/#review254
-----------------------------------------------------------

Ship it!



trunk/KDE/kdebase/workspace/plasma/shells/common/kcategorizeditemsviewdelegate.cpp
<http://reviewboard.vidsolbach.de/r/263/#comment204>

    may as well move this to the top of the method; no point in setting up all the variables if they aren't going to be used.



trunk/KDE/kdebase/workspace/plasma/shells/common/kcategorizeditemsviewmodels.cpp
<http://reviewboard.vidsolbach.de/r/263/#comment205>

    i suppose you can remove the FIXME there now?


- Aaron


On 2008-11-08 03:21:04, Alessandro Diaferia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/263/
> -----------------------------------------------------------
> 
> (Updated 2008-11-08 03:21:04)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> I thought it's the time to take care of applets' authors since they (you, me, they) have no credits shown anywhere for their job =). Ok i just found some time to implement this feature. I'd like to know if i chose the right icon for authors' info. Note that the icon only shows on hovering, i think this way it is less intrusive and appeals nicer.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/shells/common/appletbrowser.h
>   trunk/KDE/kdebase/workspace/plasma/shells/common/appletbrowser.cpp
>   trunk/KDE/kdebase/workspace/plasma/shells/common/kcategorizeditemsview.cpp
>   trunk/KDE/kdebase/workspace/plasma/shells/common/kcategorizeditemsviewdelegate.cpp
>   trunk/KDE/kdebase/workspace/plasma/shells/common/kcategorizeditemsviewdelegate_p.h
>   trunk/KDE/kdebase/workspace/plasma/shells/common/kcategorizeditemsviewmodels.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/263/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> author icon
>   http://reviewboard.vidsolbach.de/r/263/s/92/
> author dialog
>   http://reviewboard.vidsolbach.de/r/263/s/93/
> 
> 
> Thanks,
> 
> Alessandro
> 
>