Review Request: per-applet authors' info!
Alessandro Diaferia
alediaferia at gmail.com
Sat Nov 8 12:21:04 CET 2008
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/263/
-----------------------------------------------------------
(Updated 2008-11-08 03:21:04.419894)
Review request for Plasma.
Summary
-------
I thought it's the time to take care of applets' authors since they (you, me, they) have no credits shown anywhere for their job =). Ok i just found some time to implement this feature. I'd like to know if i chose the right icon for authors' info. Note that the icon only shows on hovering, i think this way it is less intrusive and appeals nicer.
Diffs
-----
trunk/KDE/kdebase/workspace/plasma/shells/common/appletbrowser.h
trunk/KDE/kdebase/workspace/plasma/shells/common/appletbrowser.cpp
trunk/KDE/kdebase/workspace/plasma/shells/common/kcategorizeditemsview.cpp
trunk/KDE/kdebase/workspace/plasma/shells/common/kcategorizeditemsviewdelegate.cpp
trunk/KDE/kdebase/workspace/plasma/shells/common/kcategorizeditemsviewdelegate_p.h
trunk/KDE/kdebase/workspace/plasma/shells/common/kcategorizeditemsviewmodels.cpp
Diff: http://reviewboard.vidsolbach.de/r/263/diff
Testing
-------
Screenshots
-----------
author icon
http://reviewboard.vidsolbach.de/r/263/s/92/
author dialog
http://reviewboard.vidsolbach.de/r/263/s/93/
Thanks,
Alessandro
More information about the Plasma-devel
mailing list