KDE/kdebase/apps/plasma/applets/folderview

Aaron J. Seigo aseigo at kde.org
Thu Jul 31 22:04:29 CEST 2008


On Thursday 31 July 2008, Carlo Segato wrote:
> SVN commit 840247 by segato:
>
> fix titletext on windows
>
>  M  +4 -0      folderview.cpp
>
>
> --- trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp
> #840246:840247 @@ -771,7 +771,11 @@
>      if (m_url == KUrl("desktop:/")) {
>          titleText = i18n("Desktop"); //FIXME: 4.2 make it "Desktop Folder;
>      } else if (m_url.isLocalFile() &&
> m_url.path().startsWith(KUrl("~").path())) { +#ifndef Q_WS_WIN
>          titleText = m_url.path().replace(KUrl("~").path(), i18n("Home"));
> +#else
> +        titleText = m_url.path().replace(QDir::homePath(), i18n("Home"));
> +#endif
>      } else {
>          titleText = m_url.pathOrUrl();
>      }

just to note: 

this is exactly the kind of platform specific #ifdef'ing i do not want to see 
in plasma code.

there are platform neutral ways to do these things; if you're unsure, ask first 
before putting in any platorm specific ifdef's. thanks =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20080731/08f6a19a/attachment.pgp 


More information about the Plasma-devel mailing list