Extender api review, round 2

Dmitry Suzdalev dimsuzkde at gmail.com
Tue Jul 29 18:47:28 CEST 2008

On Tuesday 29 July 2008 20:38:55 Aaron J. Seigo wrote:
> it's looking better and better! =)
True! :)

I spotted two things:

1. (minor) Add 'explicit' to constructor of Extender class?
2. setIsPopup/isPopup apidox don't say anything about what behavior is default! To 
popup or not to popup? :)

I always miss this in APIs - a lot of setter functions specify what will be done, but 
fail to specify what is the default behavior.
libplasma has a lot such issues too :-P. Or at least had them when i last looked.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20080729/8e7410c8/attachment.html 

More information about the Plasma-devel mailing list