Review Request: Scrollbars for the comic applet

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/310/#review299
-----------------------------------------------------------

Ship it!


good idea .. a couple small comments below, but nothing major.



/trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp
<http://reviewboard.vidsolbach.de/r/310/#comment250>

    this signal ought to be Plasma::ScrollBar itself. i'm fixing that right now, which should make your patch a little simpler =)



/trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp
<http://reviewboard.vidsolbach.de/r/310/#comment249>

    if you set the scrollbars to 0, should mScroll[Vert|Horz] also be updated?
    
    in fact, i wonder if you need mScroll[Vert|Horiz] at all; you should be able to just use mScrollBar[Vert|Horiz]->value() instead. would prevent bugs cropping up due to synchronization issues.


- Aaron


On 2008-12-15 10:54:40, Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/310/
> -----------------------------------------------------------
> 
> (Updated 2008-12-15 10:54:40)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch adds scrollbars if "Scale to content" [1] has been chosen while the comic applet was not assigned [2] enough space.
> 
> I think this is a bugfix as some comics [3] can not be shown at their original and thus most readable size as they are too large for many displays around. This gets worse for small displays.
> 
> All that would be fixed with the scrollbars, yet I'm not sure if I did implement them good enough.
> 
> 
> [1] showing them at their original size
> [2] manualy resizing by the user
> [3] xkcd, Deo Ignito, Questionable Content, Girl Genius to name a few are sometimes or allways very large (height)
> 
> 
> This addresses bug 171035.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/applets/comic/comic.h
>   /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/310/diff
> 
> 
> Testing
> -------
> 
> Tested that with trunk. Worked fine here -- some glitches left like automatically adding/removing scrollbars if the applet is resized.
> 
> 
> Thanks,
> 
> Matthias
> 
>