Review Request: some tweaks to the panel controller

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/146/#review139
-----------------------------------------------------------

Ship it!


looks like a nice incremental improvement.

i wonder if it would make sense to put some text on the outside of the min sliders, inside of the max and around the anchor point to make it really obvious, e.g. (with *s for the icons):

                  Anchor * Point 
<* Maximum                                  Maximum *>
       Minimum >                  < Minimum


/trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelcontroller.cpp
<http://reviewboard.vidsolbach.de/r/146/#comment105>

    I think we'll need a different word here other than "Position" because, from a user's POV, the position is actually controlled by the sliders below.
    
    perhaps "Screen Edge"? hmm..


- Aaron


On 2008-08-26 07:30:37, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/146/
> -----------------------------------------------------------
> 
> (Updated 2008-08-26 07:30:37)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> position and height controlled by two buttons, there is no more the resize handle
> new graphics in the ruler (that requires code change since the handles are no more symmetric)
> 
> note that resize still does not have an icon, since horizontal and vertical size are missing from oxygen
> i wonder what is the best approach, put them into oxygen icon theme or use the concept of monocromatic action icons dependent from plasma theme that i talked about some times and still too lazy to do...
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/widgets/containment-controls.svgz
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelcontroller.h
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelcontroller.cpp
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/positioningruler.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/146/diff
> 
> 
> Testing
> -------
> 
> tested with panel in all four edges
> 
> 
> Screenshots
> -----------
> 
> new look
>   http://reviewboard.vidsolbach.de/r/146/s/44/
> 
> 
> Thanks,
> 
> Marco
> 
>